Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AppRoot): set overscrollBehavior to <html> #7881

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

inomdzhon
Copy link
Contributor


  • Unit-тесты
  • Release notes

Описание

GlobalScrollController теперь установливает overscroll-behavior: none на <html>, чтобы избегать pull-to-refresh.

Release notes

Улучшения

  • useScrollLock: теперь при <AppRoot scroll="global" /> в <html> добавляется overscroll-behavior: none, чтобы избегать pull-to-refresh.

@inomdzhon inomdzhon self-assigned this Nov 1, 2024
@inomdzhon inomdzhon requested a review from a team as a code owner November 1, 2024 16:04
@inomdzhon inomdzhon added this to the v7.0.0-beta.2 milestone Nov 1, 2024
@inomdzhon inomdzhon changed the title Imirdzhamolov/feat/scroll context modify html feat(AppRoot): set overscrollBehavior to <html> Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

size-limit report 📦

Path Size
JS 382.59 KB (+0.05% 🔺)
JS (gzip) 122.42 KB (+0.04% 🔺)
JS (brotli) 101.37 KB (+0.02% 🔺)
JS import Div (tree shaking) 1.47 KB (0%)
CSS 342.2 KB (0%)
CSS (gzip) 49.32 KB (0%)
CSS (brotli) 39.95 KB (0%)

Copy link

codesandbox-ci bot commented Nov 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Nov 1, 2024

👀 Docs deployed

Commit ea6fc6d

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.36%. Comparing base (ebb46a5) to head (ea6fc6d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7881      +/-   ##
==========================================
+ Coverage   95.17%   95.36%   +0.19%     
==========================================
  Files         376      376              
  Lines       11041    11043       +2     
  Branches     3664     3664              
==========================================
+ Hits        10508    10531      +23     
+ Misses        533      512      -21     
Flag Coverage Δ
unittests 95.36% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon merged commit 667b25d into master Nov 2, 2024
28 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/feat/ScrollContext-modify-html branch November 2, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants